Skip to content

Commit

Permalink
Squash to "selftests/bpf: Add mptcp subflow subtest"
Browse files Browse the repository at this point in the history
Drop ss_search() from run_subflow().

Now ss_search() are only used by bpf_sched tests. It will be dropped
in next step.

Signed-off-by: Geliang Tang <[email protected]>
  • Loading branch information
Geliang Tang authored and intel-lab-lkp committed Aug 26, 2024
1 parent d11a08b commit fc0f0a0
Showing 1 changed file with 10 additions and 28 deletions.
38 changes: 10 additions & 28 deletions tools/testing/selftests/bpf/prog_tests/mptcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -368,22 +368,9 @@ static int endpoint_init(char *flags)
return -1;
}

static int _ss_search(char *src, char *dst, char *port, char *keyword)
static void run_subflow(void)
{
return SYS_NOFAIL("ip netns exec %s ss -enita src %s dst %s %s %d | grep -q '%s'",
NS_TEST, src, dst, port, PORT_1, keyword);
}

static int ss_search(char *src, char *keyword)
{
return _ss_search(src, ADDR_1, "dport", keyword);
}

static void run_subflow(char *new)
{
int server_fd, client_fd, err;
char cc[TCP_CA_NAME_MAX];
socklen_t len;
int server_fd, client_fd;

server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0);
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
Expand All @@ -393,19 +380,8 @@ static void run_subflow(char *new)
if (!ASSERT_GE(client_fd, 0, "connect to fd"))
goto close_server;

len = sizeof(cc);
err = getsockopt(server_fd, SOL_TCP, TCP_CONGESTION, cc, &len);
if (!ASSERT_OK(err, "getsockopt(server_fd, TCP_CONGESTION)"))
goto close_client;

send_byte(client_fd);

ASSERT_OK(ss_search(ADDR_1, "fwmark:0x1"), "ss_search fwmark:0x1");
ASSERT_OK(ss_search(ADDR_2, "fwmark:0x2"), "ss_search fwmark:0x2");
ASSERT_OK(ss_search(ADDR_1, new), "ss_search new cc");
ASSERT_OK(ss_search(ADDR_2, cc), "ss_search default cc");

close_client:
close(client_fd);
close_server:
close(server_fd);
Expand Down Expand Up @@ -441,7 +417,7 @@ static void test_subflow(void)
if (endpoint_init("subflow") < 0)
goto close_netns;

run_subflow(skel->data->cc);
run_subflow();

close_netns:
cleanup_netns(nstoken);
Expand Down Expand Up @@ -470,9 +446,15 @@ static struct nstoken *sched_init(char *flags, char *sched)
return NULL;
}

static int ss_search(char *src, char *dst, char *port, char *keyword)
{
return SYS_NOFAIL("ip netns exec %s ss -enita src %s dst %s %s %d | grep -q '%s'",
NS_TEST, src, dst, port, PORT_1, keyword);
}

static int has_bytes_sent(char *dst)
{
return _ss_search(ADDR_1, dst, "sport", "bytes_sent:");
return ss_search(ADDR_1, dst, "sport", "bytes_sent:");
}

static void send_data_and_verify(char *sched, bool addr1, bool addr2)
Expand Down

0 comments on commit fc0f0a0

Please sign in to comment.