-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change pep8 to pycodestyle for fixing failure due to reviewdog GitHub action #22
Conversation
@sbenstewart reviewdog failed, can you check what happening ? |
Looking into it. |
@NeethuES-intel The same fix in other PRs has solved the issue, so just to ensure that this failure is not caused by some sort of cache, can we trigger the review checks once more? I have another workaround too, and will merge it based on these results. |
@sbenstewart I ran reviewdog again and the same hadolint error was triggered. I believe this is unrelated to your pep8 fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
is there a way to run reviewdog using this PR changes? @brian-intel @sbenstewart |
@antoniomtz I checked the logs for reviewdog below, error is related to hadolint now, pep8 error is gone. Not sure what this hadolint error is for. |
Good job @sbenstewart @Poojarani22 for working and closing on this issue |
PR Checklist
What are you changing?
We are changing pep8 to pycodestyle , this fixes the reviewdog github action works properly.
Issue this PR will close
close: #21
Anything the reviewer should know when reviewing this PR?
Test Instructions if applicable
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/core-services )