Add log level option at compile time #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace them with `log::info` and `log::error`. Signed-off-by: Jiaqi Gao <[email protected]>
Make log level of migtd crate configurable at compile time with `cargo image` command. The default level for debug is `info` and for release is `off`. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0307/xtask_add_log_level_option
branch
from
091ac6a
to
fa0aba2
Compare
jyao1
reviewed
Mar 8, 2024
| @@ -103,7 +103,7 @@ fn handle_pre_mig() { | |||
| let coverage_len = minicov::get_coverage_data_size(); | |||
| assert!(coverage_len < MAX_COVERAGE_DATA_PAGE_COUNT * td_paging::PAGE_SIZE); | |||
| minicov::capture_coverage_to_buffer(&mut buffer[0..coverage_len]); | |||
| println!( | |||
| td_payload::println!( | |||
There was a problem hiding this comment.
why use td_payload::println? but not info! or error! ?
There was a problem hiding this comment.
Since it is test code for benchmark, maybe it will be better that it is not controlled by log level.
jyao1
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182