feat: Add mapping of vulnerable libraries to components (Fixed #1657) #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync repository
chore: update pre-commit config
* fix: add special case for 3.7 ValueError
addresses intel#1639 re.search returns `None` on failure, updating to indicate the version is `UNKNOWN` when this occurs and generating a log message
Co-authored-by: GitHub <[email protected]>
Co-authored-by: Terri Oda <[email protected]>
* feat: add detailed flag * fix: add default value * fix: default output param * test: add detailed flag test Co-authored-by: Terri Oda <[email protected]>
Co-authored-by: b31ngd3v <[email protected]>
|
Created a conflict with the excel macro filter code/tests. I believe I've resolved it. |
|
I'm confused. it claims it's failing on a line you didn't change in console.py: Were we not calling that function at all in the tests or is something else going on? I'm going to update the branch and see if that helps. |
terriko
requested changes
Jun 16, 2022
There was a problem hiding this comment.
Okay, a simple re-run didn't help. @anthonyharrison can you take a look and figure out what's going on here with the tests?
Codecov Report
@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
- Coverage 81.18% 79.21% -1.97%
==========================================
Files 299 299
Lines 6286 6356 +70
Branches 1029 1044 +15
==========================================
- Hits 5103 5035 -68
- Misses 976 1103 +127
- Partials 207 218 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.