Enable NFD rule for GPU resource driver Helm chart #68
Conversation
oxxenix
changed the title
oxxenix
changed the title
oxxenix
force-pushed
the
gpu-nfd-rule
branch
2 times, most recently
from
cd15249 to
e5bd563
Compare
| - labels: | ||
| gpu.intel.com/product: "Max_1100" | ||
| labelsTemplate: "gpu.intel.com/device.count={{"{{"}} len .pci.device {{"}}"}}" | ||
| - labelsTemplate: "gpu.intel.com/device.count={{"{{"}} len .pci.device {{"}}"}}" |
There was a problem hiding this comment.
I did not notice this earlier, but there are 4 rules for different sets of GPU IDs, each producing the same gpu.intel.com/device.count=<count> label. Which won't produce correct results on node which has GPUs from multiple rule sets.
While this is not a problem for GPU plugin because it does not support nodes with different types of Intel GPUs, DRA GPU driver is supposed to support support such use-case too.
I think it's best just to remove these rules completely for now...
There was a problem hiding this comment.
thanks! I removed these rules
There was a problem hiding this comment.
As there are still gpu.intel.com/family label rules for A_Series & Max_Series, for constency there should be also Flex_Series one, or Flex GPUs should be included to A_Series, as they're also "Alchemist" variants.
Btw. nowadays there would need to be also B_Series, but that sounds really bad for the latest & greatest Intel client platform (so such labeling would be very unlikely to be OKed by marketing). I.e. I think the family name of that should rather be e.g. Battlemage, and A_Series (which nobody's going to recognize) should rather be Alchemist...
PS. PCI IDs for these are documented here: https://dgpu-docs.intel.com/devices/hardware-table.html#gpus-with-supported-drivers
There was a problem hiding this comment.
I refactored nfd rules a bit. See the latest commit
oxxenix
force-pushed
the
gpu-nfd-rule
branch
from
dd26f4a to
abc96af
Compare
No description provided.