This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Feature/support older intel mac book pro with gcc 13 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezda
force-pushed
the
feature/support-older-Intel-MacBook-Pro-with-gcc-13
branch
4 times, most recently
from
63bd546 to
9c57593
Compare
…en/products/docs/accelerator-engines/what-is-intel-amx.html) anyway per intel#1081 (comment) Signed-off-by: Luke Nezda <[email protected]>
…ツ)_/¯ Signed-off-by: Luke Nezda <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
…ntel#1081 (comment) Signed-off-by: Luke Nezda <[email protected]>
…in this scope; did you mean 'SYS_sysctlbyname'?
ld: library not found for -lrt
collect2: error: ld returned 1 exit status
[2/164] Building CXX object models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o
FAILED: models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o
/usr/local/opt/gcc/bin/g++-13 -DNE_GELU_USE_VEC -DNE_SIMD_VEC_DOT_F16 -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/core/. -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas -O3 -DNDEBUG -std=c++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -fPIC -mf16c -mfma -mavx -mavx2 -fopenmp -MD -MT models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o -MF models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o.d -o models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o -c /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp: In function 'int32_t get_num_physical_cores()':
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp:36:16: error: 'sysctlbyname' was not declared in this scope; did you mean 'SYS_sysctlbyname'?
36 | int result = sysctlbyname("hw.perflevel0.physicalcpu", &num_physical_cores, &len, NULL, 0);
| ^~~~~~~~~~~~
| SYS_sysctlbyname
[3/164] Building CXX object models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o
FAILED: models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o
/usr/local/opt/gcc/bin/g++-13 -DNE_GELU_USE_VEC -DNE_SIMD_VEC_DOT_F16 -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/core/. -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas -O3 -DNDEBUG -std=c++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -fPIC -mf16c -mfma -mavx -mavx2 -fopenmp -MD -MT models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o -MF models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o.d -o models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o -c /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp: In function 'int32_t get_num_physical_cores()':
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp:36:16: error: 'sysctlbyname' was not declared in this scope; did you mean 'SYS_sysctlbyname'?
36 | int result = sysctlbyname("hw.perflevel0.physicalcpu", &num_physical_cores, &len, NULL, 0);
| ^~~~~~~~~~~~
| SYS_sysctlbyname
Signed-off-by: Luke Nezda <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
…ents Signed-off-by: Luke Nezda <[email protected]>
…ents Signed-off-by: Luke Nezda <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
…s too Signed-off-by: Luke Nezda <[email protected]>
…n_hidden_size, rope_scale, rope_theta - tried to fix write_vocab_only but Params here missing lots too Signed-off-by: Luke Nezda <[email protected]>
nezda
force-pushed
the
feature/support-older-Intel-MacBook-Pro-with-gcc-13
branch
from
c1f89be to
bfec292
Compare
DDEle
reviewed
Dec 29, 2023
There was a problem hiding this comment.
@zhenwei-intel Can you check it and check if there are similar problems in other models?
There was a problem hiding this comment.
@intellinjun Can you check it and check if there are similar problems in other models?
intel_extension_for_transformers/llm/runtime/graph/scripts/requirements/common.txt
Outdated
Show resolved
Hide resolved
examples/huggingface/pytorch/question-answering/pruning/group_lasso/modeling.py
Outdated
Show resolved
Hide resolved
| docker pull intel/ai-tools:itrex-devel-1.3.0 | ||
| docker pull intel/ai-tools:itrex-1.3.0-devel |
There was a problem hiding this comment.
Thanks for the correction. I'm not familiar with docker but it seems that you are right. To be confirmed by @tylertitsworth?
| db(reinterpret_cast<uintptr_t>(nullptr), sizeof(intptr_t)); // case 0 should never occur | ||
| db(nullptr, sizeof(intptr_t)); // case 0 should never occur |
There was a problem hiding this comment.
copying your error msg
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas/jblas/kernel_jit.h:1231:7: error: call of overloaded 'db(uintptr_t, long unsigned int)' is ambiguous
1231 | db(reinterpret_cast<uintptr_t>(nullptr), sizeof(intptr_t)); // case 0 should never occur
| ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas/jblas/jit_base.h:19,
from /Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas/jblas/jit_blas_storage.h:15:
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas/jblas/xbyak/xbyak.h:1133:14: note: candidate: 'void Xbyak::CodeArray::db(uint64_t, size_t)'
1133 | void db(uint64_t code, size_t codeSize)
| ^~
/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas/jblas/xbyak/xbyak.h:1129:14: note: candidate: 'void Xbyak::CodeArray::db(const uint8_t*, size_t)'
1129 | void db(const uint8_t *code, size_t codeSize)
| ^~
ninja: build stopped: subcommand failed.
I actually want the first case. Can you try reinterpret_cast<uint64_t>(nullptr) (or just UINT64_C(0) if fails)?
For curiosity, what is uintptr_t in your side?
There was a problem hiding this comment.
Hmm, original code gcc rejected with above was
db(reinterpret_cast<uintptr_t>(nullptr), sizeof(intptr_t)); // case 0 should never occurmy wild guess "fix" that is committed in this branch atm
db(nullptr, sizeof(intptr_t)); // case 0 should never occuryou've just requested
db(reinterpret_cast<uint64_t>(nullptr), sizeof(intptr_t)); // case 0 should never occurwhich seems to compile fine ¯\_(ツ)_/¯ : I will push the change.
I re-confirmed the original doesn't compile with my gcc 13.2.0. I also confirmed I still get segfaults after re-building everything with this change.
As for what uintptr_t is in my env, I really don't know how to answer that - I asked Bard "What is the difference between uintptr_t and uint64_t ?" and it sounded fairly pedantic - like they could differ if we had 128 bit pointers or something.
…uirements/common.txt Co-authored-by: Yi DING <[email protected]> Signed-off-by: Luke Nezda <[email protected]>
Co-authored-by: Yi DING <[email protected]> Signed-off-by: Luke Nezda <[email protected]>
…ツ)_/¯ - adjust per code review @DDEle Signed-off-by: Luke Nezda <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Initiated discussion #1081 to while trying to get this project to compile on a 2019 Intel-based MacBook Pro.
Currently segfaults when running inference on mistralai/Mistral-7B-v0.1 quantized as
WeightOnlyQuantConfig(ggml=True)feature or bug fix or documentation or others
API changed or not
Description
detail description
JIRA ticket: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
brew install gcc(13.2.0),export CC=/usr/local/opt/gcc/bin/gcc-13,export CXX=/usr/local/opt/gcc/bin/g++-13and building withpip install -v .Dependency Change?
any library dependency introduced or removed