This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Fix args.tasks type check issue #1675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: duansheng.liu <[email protected]>
duanshengliu
force-pushed
the
fix-tasks-type-check
branch
from
22c65e3 to
0b00719
Compare
|
https://github.com/EleutherAI/lm-evaluation-harness/blob/main/lm_eval/__main__.py#L320 the source code is there, It is not error code and used to search for the task list. |
|
Thanks , I get it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
bug fix
Description
I believe that
elif args.tasks == "list":here is a confusing typographical error, and it was originally intended to check ifargs.tasksis list type.Expected Behavior & Potential Risk
None
How has this PR been tested?
None
Dependency Change?
None