Update Licenses and Intel Copyrights + add verification #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtkaczyk
changed the title
|
Hey @tasleson, a file(s) you own were modified in this PR! Could you take a look? Caused by: |
|
Hey @nfont, a file(s) you own were modified in this PR! Could you take a look? Caused by: |
|
Hey @prabhakar, a file(s) you own were modified in this PR! Could you take a look? Caused by: |
mku514k
reviewed
May 23, 2024
mku514k
reviewed
May 23, 2024
mku514k
reviewed
May 24, 2024
Update all license headers to SPDX format. Licenses or non Intel Copyright changes are not intended. Signed-off-by: Mariusz Tkaczyk <[email protected]>
Update all license headers to SPDX format. Licenses or non Intel Copyright changes are not intended. Signed-off-by: Mariusz Tkaczyk <[email protected]>
bkucman
requested changes
May 24, 2024
Update all license headers to SPDX format. Licenses or non Intel Copyright changes are not intended. Signed-off-by: Mariusz Tkaczyk <[email protected]>
Update all license headers to SPDX format. Licenses or non Intel Copyright changes are not intended. Signed-off-by: Mariusz Tkaczyk <[email protected]>
Update all license headers to SPDX format. Licenses or non Intel Copyright changes are not intended. Signed-off-by: Mariusz Tkaczyk <[email protected]>
mku514k
reviewed
May 24, 2024
Start documenting ledmon development best practices. Signed-off-by: Mariusz Tkaczyk <[email protected]>
The script is made to control new licenses added and avoid legal problems. The most important it respect LGPL in library. Additionally, it checks Intel copyrights. Updating them with every release is pointless. Just keep the year of adding. Signed-off-by: Mariusz Tkaczyk <[email protected]>
Test each updated file. There are some files and directories excluded from testing. It is specified in review job. Update workflow to install required packages separatelly. Move github scripts to .github directory (to avoid unlicensed files in other locations). Fix requiring gcc when clang is in use (discovered after updating clang review flow). Signed-off-by: Mariusz Tkaczyk <[email protected]>
tasleson
approved these changes
May 28, 2024
|
Good catch @mku514k ! |
This is mandatory to contain full license version. Create proper directory and add verification of licence file existence in test. Signed-off-by: Mariusz Tkaczyk <[email protected]>
bkucman
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address following concerns:
Changes in license types, non-Intel copyrights are not intended.