vaGetDeviceNames inspired fixes and documentation #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XinfengZhang this and your original fixes should be backported to all releases which have DRI3 support. Thanks |
sivileri
reviewed
Jul 20, 2023
| @@ -38,18 +38,17 @@ | |||
| const char VAAPI_DEFAULT_DRIVER_NAME[] = "vaon12"; | |||
There was a problem hiding this comment.
This commit is Reviewed-by: Sil Vilerino <[email protected]>
|
windows/windows-msvc build failed |
evelikov
force-pushed
the
getdeviceslimits
branch
from
6b2bab1
to
504e0e0
Compare
Should be fixed now. As a bonus, I've rebased against latest master branch. |
The adapter_luid is already stored in pDriverContext->native_dpy. The copy in VADisplayContextWin32, is not needed. Signed-off-by: Emil Velikov <[email protected]>
All the vafool codebase was removed a while ago, with little sign of it coming back. Signed-off-by: Emil Velikov <[email protected]>
Note that the old ones are deprecated. For the new one mention the ownership model and num_drivers meaning/handling. Signed-off-by: Emil Velikov <[email protected]>
Similar to ce9898c Signed-off-by: Emil Velikov <[email protected]>
As documented (and updated) the callee(s) cannot set the num_drivers past the original size. So drop the unreachable code. Signed-off-by: Emil Velikov <[email protected]>
All the backends implement the callback. So this temporary check can go now. Signed-off-by: Emil Velikov <[email protected]>
XinfengZhang
force-pushed
the
getdeviceslimits
branch
from
504e0e0
to
ee49ceb
Compare
XinfengZhang
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively a follow-up on #731
There a couple of unrelated fixes, noticed while browsing through: