-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock mutex before return #737
Conversation
va/va_trace.c
Outdated
|
||
TRACE_FUNCNAME(idx); | ||
|
||
va_TraceMsg(trace_ctx, "\tsurfaceId = 0x%08x\n", surfaceId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked that these 3 items would be printed regardless of memType check.... Consider that someone will need to extend this function to cover other mem types - he will need to basically revert your change.
Thus, please, revert back the change and handle mutex issue in a different way, i.e. either call DPY2TRACE_VIRCTX_EXIT
before each return or use goto exit
instead of return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated.
Always release mutex before return. Signed-off-by: Jay Yang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Always release mutex before return.
Signed-off-by: Jay Yang [email protected]