va: Add VAConfigAttribEncMaxTileRows and VAConfigAttribEncMaxTileCols #757
Conversation
sivileri
force-pushed
the
add_enc_max_tile_cols_rows
branch
from
2a51e1d
to
adf810f
Compare
sivileri
changed the title
sivileri
force-pushed
the
add_enc_max_tile_cols_rows
branch
from
adf810f
to
4c925b1
Compare
…leCols Requires: intel/libva#757 Signed-off-by: Sil Vilerino <[email protected]>
sivileri
force-pushed
the
add_enc_max_tile_cols_rows
branch
from
4c925b1
to
a5b62cc
Compare
Currently there is no way of exposing the driver tile_rows and tile_cols limitations for encoding with tiles. For codecs like AV1 there is a cap specifying the max number of tiles, but without differentiating cols/rows. Different hardware may have restrictions which may need to be taken into account. More specifically, D3D12 encode exposes the maximum rows/cols and adding VAConfigAttribEncMaxTileRows/Cols allows for mapping that information to the VAOn12 driver. Signed-off-by: Sil Vilerino <[email protected]>
sivileri
force-pushed
the
add_enc_max_tile_cols_rows
branch
from
a5b62cc
to
e5758c4
Compare
@XinfengZhang thanks for taking a look. We've discussed this previously with @dvrogozh . It may be easier for the user to have separate values instead of having to deal with bit manipulation, there are other caps like Do you think keeping the separate values would be okay for 
|
|
These attributes are not directly involved in bitstream packing. In such cases I think it's better to favor usability over compactness. |
|
@XinfengZhang kindly pinging on this MR :) |
…leCols Requires: intel/libva#757 Signed-off-by: Sil Vilerino <[email protected]>
…leCols Requires: intel/libva#757 Signed-off-by: Sil Vilerino <[email protected]>
Currently there is no way of exposing the driver tile_rows and tile_cols limitations for encoding with tiles. For codecs like AV1 there is a cap specifying the max number of tiles, but without differentiating cols/rows.
Different hardware may have restrictions which may need to be taken into account. More specifically, D3D12 encode exposes the maximum rows/cols and adding VAConfigAttribEncMaxTileRows/Cols allows for mapping that information to the VAOn12 driver.
Related vainfo change: intel/libva-utils#344
@dvrogozh @XinfengZhang