windows.yml: Add windows-msvc-debug #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a debug build type run to catch errors only happening on debug
sivileri
force-pushed
the
ci_windows_debug-1
branch
from
6cbddd5
to
c81bf3f
Compare
XinfengZhang
approved these changes
Sep 28, 2023
|
This should really be a matrix IMHO. We've removed a bunch of duplication in the CI before, it'll be great if we don't reintroduce that. |
|
Actually, matrix complicates things. To me, current workflow is simple enough and is not yet complex enough to justify introducing test matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a debug build type run to catch errors only happening on debug
@dvrogozh @evelikov @XinfengZhang