0927 1 #116
Merged
0927 1 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default value for LOGFILE to make sure lkvs log could be recorded and it could avoid the issue when runtest without logfile situation also. Signed-off-by: Pengfei Xu <[email protected]>
Shell read command will be cleared in the vm test, ensure all the test TODO list are not cleared before testing, improve the TODO list way. Signed-off-by: Pengfei Xu <[email protected]>
ysun
reviewed
Sep 27, 2023
| @@ -158,7 +163,8 @@ test_all() { | |||
| fi | |||
| } | |||
|
|
|||
| : LOGFILE="" | |||
| # Default value | |||
| : "${LOGFILE:="./lkvs.log"}" | |||
There was a problem hiding this comment.
Hi Pengfei, is this correct ?
There was a problem hiding this comment.
As before I wrote as following:
: ${LOGFILE:="./lkvs.log"}
And met below warning:
https://www.shellcheck.net/wiki/SC2223
And fixed above warning to write as present sample.
The double quotes within the curly braces will not conflict with the double quotes outside the curly braces, and there is no problem with the test.
Thanks!
…e is too long VM case result is long like as following: guest.test_launcher.sh -v 1 -s 1 -m 1 -d on -t tdx -x TD_BOOT -c "accept_memory=lazy" -p offPASS 0 21.070s Add one space and make the result more clearly as following: guest.test_launcher.sh -v 1 -s 1 -m 1 -d on -t tdx -x TD_BOOT -c "accept_memory=lazy" -p off PASS 0 21.000s Signed-off-by: Pengfei Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.