Supplementary header file #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please re-write the description for both commits. |
ysun
requested changes
Dec 28, 2023
workload-xsave/yogini.c
Outdated
| @@ -284,6 +283,8 @@ static void cmdline(int argc, char **argv) | |||
| case 'f': | |||
| clfulsh = 1; | |||
| break; | |||
| case '?': | |||
There was a problem hiding this comment.
Hi Haoliang， incorrect indent here.
workload-xsave/yogini.h
Outdated
| @@ -74,7 +74,7 @@ struct workload *(*all_register_routines[]) () = { | |||
| register_SSE, | |||
| register_MEM, | |||
| register_memcpy, | |||
| register_AMX, | |||
| s register_AMX, | |||
1.Modify u_int8_t to uint8_t. Signed-off-by: Haoliang Zhu <[email protected]>
haoliang-Zhu
force-pushed
the
cmake
branch
8 times, most recently
from
c459d6e
to
40db7a9
Compare
1.Missing uint8_t header file. 2.Supplement useage information. Signed-off-by: Haoliang Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplement the missing header files in the workload-xsave folder.Modify the yogini source file and output help when input is missing.