cmpccxadd: add 40 functional cases #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysun
requested changes
May 24, 2024
There was a problem hiding this comment.
Hi @jiaanlu
Thank you for your PR; it's a really good test! However, we encountered dozens of coding style check failures. Could you please fix as many of them as possible?
And how do you think if merging all those cmpbexadd_*.c into a single file, which will simply the program a lot?
|
jiaanlu
force-pushed
the
main
branch
5 times, most recently
from
080d7e1
to
6fe9172
Compare
Signed-off-by: Jiaan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 40 basic function check for CMPccXADD on bare metal.