Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amx] Test Enhance: move test src to top folder #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hongyuni
Copy link
Contributor

@hongyuni hongyuni commented Sep 6, 2024

move test source code to top folder amx to align with all other features hierarchy, for runtests.py execution alignment

[Test Components] amx
[Test Types] any
[Supported Devices] all-generic

move test source code to top folder amx to align with all other features
hierarchy, for runtests.py execution alignment

[Test Components] amx
[Test Types] any
[Supported Devices] all-generic

Signed-off-by: Hongyu Ning <[email protected]>
Copy link
Contributor

@ysun ysun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concern moving tmul to the top folder.
1, tmul is part of AMX i think. It is too small to take it as a "feature". I prefer keep tmux in AMX folder, at least move all source code into AMX folder.
2, I'm not sure whether it would impact the external framwork like eoch or ancert AMX test execution.

@hongyuni
Copy link
Contributor Author

hongyuni commented Sep 10, 2024

I have concern moving tmul to the top folder. 1, tmul is part of AMX i think. It is too small to take it as a "feature". I prefer keep tmux in AMX folder, at least move all source code into AMX folder. 2, I'm not sure whether it would impact the external framwork like eoch or ancert AMX test execution.

  1. Thanks. It makes sense to me, for future larger scope of AMX testing, keep tmul test src inside tmul sub-folder is a better option
  2. if eoch or ancert AMX test execution is using runtests.py, just make sure to use command as discussed in amx tests can not be run with runtests.py #396
    $ ./runtests.py -f amx/tmul -t amx/tests

rli9 added a commit to intel/lkp-tests that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants