instruction_check: enhancement #405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhao22
reviewed
Sep 25, 2024
BM/instruction-check/feature_list.py
Outdated
| }, | ||
| "PREFETCHI": { | ||
| "cpuid": ['7', '0', '1', '0', 'd', '14'], | ||
| "platforms": {"SPR", "EMR", "GNR"} |
There was a problem hiding this comment.
I don't think SPR/EMR support PREFETCHI.
BM/instruction-check/feature_list.py
Outdated
| }, | ||
| "FRED": { | ||
| "cpuid": ['7', '0', '1', '0', 'a', '17'], | ||
| "platforms": {} |
There was a problem hiding this comment.
What does the empty of platforms mean? Seems FRED only be supported on CWF and DMR.
BM/instruction-check/feature_list.py
Outdated
| }, | ||
| "AMX_FP16": { | ||
| "cpuid": ['7', '0', '1', '0', 'a', '21'], | ||
| "platforms": {"SPR", "EMR", "GNR"} |
There was a problem hiding this comment.
Seems SPR/EMR doesn't support AMX_FP16.
Did you test your patch on these platform?
There was a problem hiding this comment.
Thank you for your suggestion. I previously conducted tests on SPR, GNR, and SRF, but there may be some errors. I will double-check.
1. Depending on the platform, different test cases are executed now. 2. Some other optimizations to enhance the robustness of the code. Signed-off-by: Haoliang Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the platform, different test cases are executed now and some other optimizations to enhance the robustness of the code.