Review updates

Author: PatKamin

devops/scripts/benchmarks/benches/base.py

@@ -287,8 +287,12 @@ def taskset_cmd(self) -> list[str]:
             ) as f:
                 freq = int(f.read().strip())
                 core_frequencies.append((core, freq))
-        core_frequencies.sort(key=lambda x: x[1], reverse=True)
-        cores_list = ",".join([str(core) for core, _ in core_frequencies[:4]])
+        selected = core_frequencies[:4]  # first ones have highest frequency
+        if len({freq for _, freq in selected}) > 1:
+            log.warning(
+                f"Selected cores for pinning have differing max frequencies: {selected}"
+            )
+        cores_list = ",".join([str(core) for core, _ in selected])
         return ["taskset", "-c", cores_list]
 
 

devops/scripts/benchmarks/requirements.txt

@@ -3,3 +3,4 @@ mpld3==0.5.10
 dataclasses-json==0.6.7
 PyYAML==6.0.1
 Mako==1.3.0
+psutil>=7.0.0