Implement work_group_static / work_group_scratch_memory #15061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented basic interface Implemented skeleton to lower dynamic case TODO: implement compile time kernel property update extension
…o place work_group_static in local memory.
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Lukas Sommer <[email protected]>
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
pushed a commit
to Naghasan/unified-runtime
that referenced
this pull request
Dec 3, 2024
intel/llvm#15061 introduces a new property work_group_scratch_memory which allow the user to set a given amount of local memory to be used. In order to pass this information to the adaptor, the patch adds a new launch property to urEnqueueKernelLaunchCustomExp. The patch also changes the signature of urEnqueueKernelLaunchCustomExp to add global offset in order to maintain features when using this extension. Signed-off-by: Victor Lomuller <[email protected]>
Naghasan
added a commit
to Naghasan/unified-runtime
that referenced
this pull request
Dec 3, 2024
intel/llvm#15061 introduces a new property work_group_scratch_memory which allow the user to set a given amount of local memory to be used. In order to pass this information to the adaptor, the patch adds a new launch property to urEnqueueKernelLaunchCustomExp. The patch also changes the signature of urEnqueueKernelLaunchCustomExp to add global offset in order to maintain features when using this extension. Signed-off-by: Victor Lomuller <[email protected]>
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Naghasan
added a commit
to Naghasan/unified-runtime
that referenced
this pull request
Dec 3, 2024
intel/llvm#15061 introduces a new property work_group_scratch_memory which allow the user to set a given amount of local memory to be used. In order to pass this information to the adaptor, the patch adds a new launch property to urEnqueueKernelLaunchCustomExp. The patch also changes the signature of urEnqueueKernelLaunchCustomExp to add global offset in order to maintain features when using this extension. Signed-off-by: Victor Lomuller <[email protected]>
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Dec 4, 2024
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@Naghasan Postcommit is failing, can you take a look? https://github.com/intel/llvm/actions/runs/12161776918/job/33917149437 https://github.com/intel/llvm/actions/runs/12161776918/job/33917148531 |
|
on it 👀 |
Naghasan
added a commit
to Naghasan/llvm
that referenced
this pull request
Dec 4, 2024
fix compilation issue introduced by intel#15061
sarnex
pushed a commit
that referenced
this pull request
Dec 4, 2024
bader
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch partially implements
work_group_staticand update proposal.Implemented:
work_group_staticto handle static allocation in kernel.get_dynamic_work_group_memoryto handle runtime allocation, but only on CUDAwork_group_staticis implemented by exposingSYCLScope(WorkGroup), allowing the class to be decorated by the attribute and uses the same mechanism during lowering to place the variable in local memory.get_dynamic_work_group_memoryuses a new builtin function,__sycl_dynamicLocalMemoryPlaceholder, which is lowered into referencing a 0 sized array GV when targeting NVPTX. The approach for SPIR will need to differ from this lowering.UR change oneapi-src/unified-runtime#1968, oneapi-src/unified-runtime#2403