Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] [E2E] fix reenabled tests #15975

Merged
merged 16 commits into from
Dec 19, 2024
Merged

[SYCL] [E2E] fix reenabled tests #15975

merged 16 commits into from
Dec 19, 2024

Conversation

dklochkov-emb
Copy link
Contributor

No description provided.

@dklochkov-emb dklochkov-emb self-assigned this Nov 4, 2024
@dklochkov-emb dklochkov-emb requested a review from a team as a code owner November 4, 2024 15:19
@dklochkov-emb dklochkov-emb marked this pull request as draft November 4, 2024 15:19
@dklochkov-emb dklochkov-emb marked this pull request as ready for review November 13, 2024 13:40
cperkinsintel
cperkinsintel reviewed Nov 14, 2024
View reviewed changes
sycl/test-e2e/Basic/interop/Interop_level_zero_backend.cpp Outdated
@@ -0,0 +1,85 @@
// RUN: %if any-device-is-level_zero %{ %{build} -isystem %sycl_include -DBUILD_FOR_L0 -o %t-l0.out %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is BUILD_FOR_L0 still used? I think it can be dropped, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, dropped. Thanks.

AlexeySachkov
AlexeySachkov reviewed Nov 15, 2024
View reviewed changes
sycl/test-e2e/Basic/interop/Interop_level_zero_backend.cpp Outdated
@@ -0,0 +1,85 @@
// RUN: %if any-device-is-level_zero %{ %{build} -isystem %sycl_include -o %t-l0.out %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests which do not execute anything, but only check compilation, should be placed under sycl/test and they should use -fsyntax-only flag as well.

I'm fine with old tests still staying incorrect and be fixed in separate PR, but new tests should be written in a right way.

An alternative is to actually run an executable you build here, because you seem to have a full test. In that case you don't need any %if. Just say REQUIRES: level_zero.

Also, I don't think that you need -isystem %sycl_include at all. %{build} automatically passes -fsycl and the latter sets up all necessary include paths automatically.

Copy link
Contributor Author

@dklochkov-emb dklochkov-emb Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed because sycl/test exist: sycl/test/basic_tests/interop-level-zero-2020.cpp and sycl/test/basic_tests/interop-backend-traits-level-zero.cpp

@dklochkov-emb
Copy link
Contributor Author

@AlexeySachkov @cperkinsintel @aelovikov-intel Please, review changes

@dklochkov-emb
Copy link
Contributor Author

@aelovikov-intel @cperkinsintel please review it

@dklochkov-emb
Copy link
Contributor Author

@aelovikov-intel @cperkinsintel please review it

@AlexeySachkov AlexeySachkov merged commit 0181367 into intel:sycl Dec 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel

Assignees

@dklochkov-emb dklochkov-emb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dklochkov-emb @cperkinsintel @AlexeySachkov @aelovikov-intel