[SYCL] Use inheritance to implement oneapi properties #16024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
properties-inheritance
branch
from
744852d
to
35c51ea
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
properties-inheritance
branch
from
35c51ea
to
0e556ce
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
changed the title
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
properties-inheritance
branch
from
0e556ce
to
8fa4d79
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Nov 12, 2024
|
Ping @steffenlarsen |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Nov 13, 2024
| sycl::ext::oneapi::experimental::empty_properties_t InvalidPropertyList7{ | ||
| sycl::ext::oneapi::experimental::foo{0}}; | ||
| /* | ||
| // TODO: Uncomment these lines once https://github.com/intel/llvm/issues/13677 | ||
| // has been fixed. |
There was a problem hiding this comment.
Suppose #13677 can be closed, even if it's not necessarily fixed? 🤔
# Conflicts: # sycl/test/check_device_code/group_load.cpp # sycl/test/check_device_code/group_store.cpp
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @rolandschulz 's #13776.
The only remaining boost/mp11 usage is to sort/filter properties, I'm going to remove that in a separate PRs.
I've also left multiple utilities (that accept variadic pack) still using
std::tupleas their implementation detail. That can be cleaned up separately as well.Closes #13677.