Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fixed-size groups and partitions are renamed to "chunks" #16151

Draft
wants to merge 9 commits into
base: sycl
Choose a base branch
from

Conversation

AndreiZibrov
Copy link
Contributor

Part 1: fix for #15721 review

@AndreiZibrov AndreiZibrov marked this pull request as draft November 22, 2024 17:06
sycl/test-e2e/NonUniformGroups/chunk.cpp Show resolved Hide resolved
sycl/test-e2e/NonUniformGroups/chunk.cpp Show resolved Hide resolved
@@ -157,7 +156,7 @@ template <typename T, int N> struct get_elem_type_unqual<vec<T, N>> {
template <typename VecT, typename OperationLeftT, typename OperationRightT,
template <typename> class OperationCurrentT, int... Indexes>
struct get_elem_type_unqual<SwizzleOp<VecT, OperationLeftT, OperationRightT,
OperationCurrentT, Indexes...>> {
OperationCurrentT, Indexes...>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, there should be no unrelated formatting changes, but in this particular case it is more of a nitpicking and can be ignored.

Copy link
Contributor Author

@AndreiZibrov AndreiZibrov Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting task failed until I called clang-format -i per changed file

upd:
not-strictly:

cd ../llvm &&
git diff --cached --name-only --diff-filter=ACM | grep '\.[ch]pp$'|xargs -I{} clang-format -i```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topic will be resolved with next commit.

The clang-format tool could be used for essential code as Alexei Sachkov has shared

Previously used way is patching only the changed files but not the file regions

export PATH="$(pwd)/build/bin:$PATH"
git diff -U0 --no-color --relative HEAD^ | $(find -name clang-format-diff.py) -p1 -i

@AlexeySachkov
Copy link
Contributor

As @steffenlarsen said in the original #15721, we should change all non-uniform groups at about the same time, so let's keep this one as a draft until other PRs for other non-uniform groups are ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants