-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Fixed-size groups and partitions are renamed to "chunks" #16151
base: sycl
Are you sure you want to change the base?
Conversation
@@ -157,7 +156,7 @@ template <typename T, int N> struct get_elem_type_unqual<vec<T, N>> { | |||
template <typename VecT, typename OperationLeftT, typename OperationRightT, | |||
template <typename> class OperationCurrentT, int... Indexes> | |||
struct get_elem_type_unqual<SwizzleOp<VecT, OperationLeftT, OperationRightT, | |||
OperationCurrentT, Indexes...>> { | |||
OperationCurrentT, Indexes...>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, there should be no unrelated formatting changes, but in this particular case it is more of a nitpicking and can be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the formatting task failed until I called clang-format -i per changed file
upd:
not-strictly:
cd ../llvm &&
git diff --cached --name-only --diff-filter=ACM | grep '\.[ch]pp$'|xargs -I{} clang-format -i```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Topic will be resolved with next commit.
The clang-format tool could be used for essential code as Alexei Sachkov has shared
Previously used way is patching only the changed files but not the file regions
export PATH="$(pwd)/build/bin:$PATH"
git diff -U0 --no-color --relative HEAD^ | $(find -name clang-format-diff.py) -p1 -i
As @steffenlarsen said in the original #15721, we should change all non-uniform groups at about the same time, so let's keep this one as a draft until other PRs for other non-uniform groups are ready |
Part 1: fix for #15721 review