Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Joint Matrix] Update apply to make both matrices read/write #16155

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Nov 21, 2024

Spec change was added in #13153
It states that the overload of joint_matrix_apply that takes two matrices can modify both matrices.
I also updated the test to reflect the change.

@dkhaldi dkhaldi requested a review from a team as a code owner November 21, 2024 21:19
@dkhaldi dkhaldi requested a review from a team December 4, 2024 22:15
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving joint_matrix_activation test to IGC repo, since it is regression test intended for bug fix in IGC. It doesn't increase test coverage for SYCL compiler implementation of SYCL Joint Matrix, but rather generates yet another variant of IR, which IGC should be able to handle.

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Dec 5, 2024

I suggest moving joint_matrix_activation test to IGC repo, since it is regression test intended for bug fix in IGC. It doesn't increase test coverage for SYCL compiler implementation of SYCL Joint Matrix, but rather generates yet another variant of IR, which IGC should be able to handle.

Since when we add SYCL tests to IGC. IGC takes binaries from this SYCL suite.

@YuriPlyakhin
Copy link
Contributor

I suggest moving joint_matrix_activation test to IGC repo, since it is regression test intended for bug fix in IGC. It doesn't increase test coverage for SYCL compiler implementation of SYCL Joint Matrix, but rather generates yet another variant of IR, which IGC should be able to handle.

Since when we add SYCL tests to IGC. IGC takes binaries from this SYCL suite.

The test in IGC would not be using "SYCL" language. It would be LLVM IR or SPIRV running through ocloc. This process is simpler/faster than add tests to SYCL repo, then build binaries, then add to IGC testing. Also, it would run as pre-checkin for each IGC PR, which makes it faster to catch regressions. I suggest we discuss the details in the call. Also, maybe the test is not necessary at all, since there is a lit test together with IGC bug fix, which maybe enough already. Again, let's discuss it on the call.

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit: PR description needs update to remove the line about adding new test.

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Dec 9, 2024

@intel/llvm-gatekeepers, please help merge this PR.

@sarnex sarnex merged commit 5e7de51 into intel:sycl Dec 9, 2024
14 checks passed
KornevNikita pushed a commit that referenced this pull request Feb 19, 2025
…16155)

Spec change was added in #13153
It states that the overload of joint_matrix_apply that takes two
matrices can modify both matrices.
I also updated the test to reflect the change.
KornevNikita pushed a commit that referenced this pull request Feb 25, 2025
…16155)

Spec change was added in #13153
It states that the overload of joint_matrix_apply that takes two
matrices can modify both matrices.
I also updated the test to reflect the change.
KornevNikita pushed a commit that referenced this pull request Feb 25, 2025
…16155)

Spec change was added in #13153
It states that the overload of joint_matrix_apply that takes two
matrices can modify both matrices.
I also updated the test to reflect the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants