[SYCL][Graph] Implement ext_oneapi_weak_object for command_graph class #16209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Nov 28, 2024
Bensuo
commented
- Add owner_less and weak_object support for the command_graph class
- Unit test which creates objects for all graph states and tests using them in a map
Bensuo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
- Add owner_less and weak_object support for the command_graph class - Unit test which creates objects for all graph states and tests using them in a map
Bensuo
force-pushed
the
ben/ownerless-graph
branch
from
9e0c05a to
dd60cb2
Compare
EwanC
approved these changes
Dec 2, 2024
- Use breaking changes macro to guard new inheritance change to preserve ABI compatibility - Improve ownerless unit test to check both weak_object and normal object usage correctly - Revert changes to windows symbol dump (as no new symbols are now exported).
EwanC
reviewed
Dec 3, 2024
aelovikov-intel
approved these changes
Dec 9, 2024
|
@intel/llvm-gatekeepers This should be ready to merge, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.