Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use devops dir from sycl on sycl-rel nightly #17004

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

KornevNikita
Copy link
Contributor

To keep sycl-rel nightly testing up to date we need to use devops/actions from sycl branch. This change adds new input to specify the ref for devops dir checkout.
#16816 (comment)

To keep sycl-rel nightly testing up to date we need to use
devops/actions from sycl branch. This change adds new input to specify
the ref for devops dir checkout.
@@ -90,7 +90,6 @@ jobs:
with:
sparse-checkout: |
devops/actions
ref: ${{ inputs.ref || github.sha }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: just aligned this with sycl-linux-build.yml

@@ -197,7 +207,7 @@ jobs:
sudo bash -c 'echo 1 > /sys/kernel/debug/dri/0/i915_wedged'
- uses: actions/checkout@v4
with:
ref: ${{ inputs.ref }}
ref: ${{ inputs.devops_ref || inputs.ref }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option - may be we can drop ref at all so actions/checkout@v4 will use github.sha as by default.

Copy link
Contributor

@aelovikov-intel aelovikov-intel Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still [want to] have CUDA on AWS testing. Due to its setup it can't use pull_request trigger and uses pull_request_target trigger. IIUC, the ref input is mostly to support such scenario (although I might be wrong here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you mean this one? As I understand it's not used for ~6months and we don't have AWS runners anymore or? Nick made these changes, so @sarnex can we just drop ref args at all? Like

Suggested change
ref: ${{ inputs.devops_ref || inputs.ref }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still run it in Nightly:

cuda-aws-start:
needs: [ubuntu2204_build]
if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }}
uses: ./.github/workflows/sycl-aws.yml
secrets: inherit
with:
mode: start
cuda-run-tests:
needs: [ubuntu2204_build, cuda-aws-start]
if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }}
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: CUDA E2E
runner: '["aws_cuda-${{ github.run_id }}-${{ github.run_attempt }}"]'
image: ghcr.io/intel/llvm/ubuntu2204_build:latest
image_options: -u 1001 --gpus all --cap-add SYS_ADMIN --env NVIDIA_DISABLE_REQUIRE=1
target_devices: cuda:gpu
ref: ${{ github.sha }}
sycl_toolchain_artifact: sycl_linux_default
sycl_toolchain_archive: ${{ needs.ubuntu2204_build.outputs.artifact_archive_name }}
sycl_toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.artifact_decompress_command }}

because we don't want the infrastructure support to rot.

type: string
required: False
description: |
By default we checkout the devops directory from "inputs.ref" branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we ever want this to be different? shouldnt we always use the current version from the sycl branch?

Copy link
Contributor Author

@KornevNikita KornevNikita Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. So this first checkout defines which devops/actions/cleanup and devops/actions/cached_checkout scripts are used. Are there cases when you need to use the script from your branch, not from sycl, e.g. If you need to test changes in cached_checkout?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive never had to, since we should always use the workflow/script in the current PR which is always what i wanted

@KornevNikita
Copy link
Contributor Author

@sarnex @aelovikov-intel so i'm a bit confused - what should I do here? just stay with the introduced solution or change something?

@sarnex
Copy link
Contributor

sarnex commented Feb 14, 2025

if we don't need devops_ref for this to work i would prefer we remove it and always use sycl branch head

@aelovikov-intel
Copy link
Contributor

if we don't need devops_ref for this to work i would prefer we remove it and always use sycl branch head

How are we going to test changes in devops/actions/run-tests/e2e/action.yml then?

@sarnex
Copy link
Contributor

sarnex commented Feb 14, 2025

ah yeah i see, we can't use ref like we do for normal PRs because the PR may be from the sycl-rel branch, this pr is fine then

@KornevNikita
Copy link
Contributor Author

fail: #17008

@sarnex sarnex merged commit 311fdc4 into sycl Feb 14, 2025
24 of 25 checks passed
@KornevNikita KornevNikita deleted the use-sycl-devops-actions branch February 17, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants