[sycl][e2e][bindless-images] Refactor bindless tests: separate out functionality #17045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
For a description of the SYCL specific features that are failing (upon pull down of the upstream commit f9c8c01) in read_write_1D_buffer.cpp and read_write_1D_range.cpp see #16503 (comment) |
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
approved these changes
Feb 20, 2025
|
@intel/llvm-gatekeepers this is ready for merge. Thanks The failed test (Prefix_Local_sum3.cpp) is unrelated and occurring in multiple PRs. See this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out bindless-image tests into more unit-test like tests for orthogonal functionality. This reduces the number of tests that fail in #16503 when the upstream commit, f9c8c01 , is pulled down, from 7 to three. This also demonstrates that essentially all bindless-image functionality that maps directly to cuda (those using nd range or USM) work correctly even with the upstream pulldown, whereas some functionality that is SYCL specific (range parallel_for or buffers) fail. Complete information is described in the associated issue #16503 (comment)
All the tests pass with the current DPC++ tip, but three of the tests fail when the above mentioned upstream commit is pulled down.
Additionally this PR removes the duplicate read_write_1D.cpp and read_2D_dynamic.cpp tests which match almost identically with the corresponding named tests in the examples folder. This is done to reduce unnecessary maintenance overhead.