Remove unnecessary and confusing unique_ptr usage #17144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldrumm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
there's another use of this pattern here https://github.com/intel/llvm/blob/sycl/unified-runtime/source/adapters/cuda/platform.cpp#L30 and I think that's the last usage of |
|
On Tue Feb 25, 2025 at 10:14 AM GMT, aarongreig wrote:
there's another use of this pattern here
https://github.com/intel/llvm/blob/sycl/unified-runtime/source/adapters/cuda/platform.cpp#L30
and I think that's the last usage of `cuda_params_unique_handle_t` so
could delete that definition as well
Good find. I'll update that one too.
|
ldrumm
force-pushed
the
no_unique_ptr
branch
from
5ac8ef3 to
c807c6a
Compare
ldrumm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ldrumm
force-pushed
the
no_unique_ptr
branch
from
c807c6a to
6cf9388
Compare
ldrumm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
approved these changes
Feb 25, 2025
npmiller
approved these changes
Feb 25, 2025
ldrumm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ldrumm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
`std::unique_ptr` was being used as a scoped deleter for a UMF value, but this was both confusing and more expensive than it needed to be. Here we introduce the simple `OnScopeExit` class which calls a callable when it goes out of scope, and use it here to simplify the meaning and overhead of the CUDA adapter's UMF pool allocation.
ldrumm
force-pushed
the
no_unique_ptr
branch
from
6cf9388 to
b34d4e0
Compare
ldrumm
requested a deployment
to
WindowsCILock
GitHub Actions
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::unique_ptrwas being used as a scoped deleter for a UMF value, but this was both confusing and more expensive than it needed to be.Here we introduce the simple
OnScopeExitclass which calls a callable when it goes out of scope, and use it here to simplify the meaning and overhead of the CUDA adapter's UMF pool allocation.