[SYCL] Re-assign HIP device aspeects #18835
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit, in addition to some minor formatting:
* Adds the fp16 aspect to all devices.
* Adds the atomic64 aspect to the two tested devices (gfx90a & gfx1030)
* The runtime reports this aspect based on querying the device for
'int64' attributes, which doesn't seem right as the aspect covers
fp64 atomics too.
* Removes the usm_system_allocations from all devices
* As best as I can see this will depend on things like PCIe so is not
(currently) possible to determine in the compiler.
GeorgeWeb
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit, in addition to some minor formatting: