Skip to content

[SYCL][NFC] Pass adapter by reference in backend[_impl] #19187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jun 27, 2025

It's a part of larger refactoring effort to pass adapter via reference instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184

@uditagarwal97 uditagarwal97 self-assigned this Jun 27, 2025
@uditagarwal97 uditagarwal97 force-pushed the private/udit/adapter_refac2 branch from 4c31021 to 0ee6f51 Compare June 27, 2025 14:35
@uditagarwal97 uditagarwal97 marked this pull request as ready for review June 27, 2025 14:37
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner June 27, 2025 14:37
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@uditagarwal97
Copy link
Contributor Author

Failure in Windows BMG:

********************
Failed Tests (3):
  SYCL :: Adapters/level_zero/ext_intel_cslice.cpp
  SYCL :: Adapters/level_zero/ext_intel_queue_index.cpp
  SYCL :: Adapters/sycl-ls-uuid-subdevs.cpp

********************
Unexpectedly Passed Tests (5):
  SYCL :: bindless_images/array/fetch_handle_carray2d.cpp
  SYCL :: bindless_images/read_1D_O0.cpp
  SYCL :: bindless_images/sampled_fetch/fetch_1D_O0.cpp
  SYCL :: bindless_images/sampled_fetch/fetch_2D_O0.cpp
  SYCL :: bindless_images/sampling_1D_O0.cpp

Adapter tests were marked XFAIL in #19242 and Bindless images tests were fixed in #19215. All of these test failures are unrelated to this PR. Merging.

@uditagarwal97 uditagarwal97 merged commit b747578 into sycl Jul 1, 2025
40 of 46 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit/adapter_refac2 branch July 1, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants