Skip to content

[libclc] Add missing clc_lgamma_r with generic address space pointer arg (#146495) #19255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wenju-he
Copy link
Contributor

@wenju-he wenju-he commented Jul 2, 2025

There is no change to amdgcn--amdhsa.bc and nvptx64--nvidiacl.bc because __opencl_c_generic_address_space is not defined for them.

(cherry picked from commit b0e6faa)
This PR fixes pre-commit CI error in #19231: undefined hidden symbol: __clc_lgamma_r(float, int*)

…arg (#146495)

There is no change to amdgcn--amdhsa.bc and nvptx64--nvidiacl.bc because
__opencl_c_generic_address_space is not defined for them.

(cherry picked from commit b0e6faa)
@wenju-he wenju-he requested a review from a team as a code owner July 2, 2025 00:42
@wenju-he wenju-he requested a review from jchlanda July 2, 2025 00:42
@wenju-he wenju-he temporarily deployed to WindowsCILock July 2, 2025 00:42 — with GitHub Actions Inactive
@wenju-he wenju-he requested a review from frasercrmck July 2, 2025 00:42
@wenju-he wenju-he temporarily deployed to WindowsCILock July 2, 2025 02:48 — with GitHub Actions Inactive
@wenju-he wenju-he temporarily deployed to WindowsCILock July 2, 2025 02:48 — with GitHub Actions Inactive
@wenju-he
Copy link
Contributor Author

wenju-he commented Jul 2, 2025

@intel/llvm-gatekeepers please merge, thanks

@steffenlarsen steffenlarsen merged commit 205aa71 into intel:sycl Jul 2, 2025
25 checks passed
@wenju-he wenju-he deleted the cherry-pick-clc_lgamma_r-generic branch July 3, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants