[UR] Update PYTHON_EXECUTABLE to Python3_EXECUTABLE in cmake #19637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${Python3_EXECUTABLE} is what is set by FindPython3 and is
what is used everywhere else.
${PYTHON_EXECUTABLE} may be unset depending, causing the
build to fail.
pbalcer
approved these changes
Jul 30, 2025
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${Python3_EXECUTABLE}is what is set by FindPython3 and is what is used everywhere else.${PYTHON_EXECUTABLE}may be unset depending, causing the build to fail.This failure case gets hit when compiling under NixOS for example
There's a few instances of
PYTHON_EXECUTABLEleft in upstream LLVM, though I haven't verified whether it builds properly with those changed toPython3_EXECUTABLE, so they're untouched here.