[SYCL] Add sycl-jit e2e feature #19724
Conversation
The project may be built with --disable-jit
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/test-e2e/lit.cfg.py
Outdated
| @@ -970,6 +970,9 @@ def get_sycl_ls_verbose(sycl_device, env): | |||
| config.available_features.add("device-config-file") | |||
| config.substitutions.append(("%device_config_file_include_flag", "")) | |||
|
|
|||
| if config.enable_sycl_jit == "ON": | |||
There was a problem hiding this comment.
Looks like in other cases (e.g config.allow_unknown_arch) we just check the value of variable like:
if not config.allow_unknown_arch:
Anybody knows - why it doesn't work here?
There was a problem hiding this comment.
Not sure if relevant: #18893
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Doesn't work as expected, moving to draft for now. |
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-devops-reviewers this pre-commit looks really weird, like something was broken. I believe it's impossible for my patch, right? |
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@againull could you please take one more look? |
| elif platform.system() == "Windows": | ||
| if os.path.exists(os.path.join(config.sycl_libs_dir, "sycl-jit.lib")): | ||
| config.available_features.add("sycl-jit") |
There was a problem hiding this comment.
NIT: sycl-jit.lib is required at compile time, but at runtime, sycl-jit.dll must be available in the PATH. However, since the .lib and .dll are typically distributed together, I believe checking for the .lib should be sufficient.
There was a problem hiding this comment.
Actually it's probably better to check only for dll in this case.
Currently in implementation sycl-jit.dll and sycl-jit.so are loaded at runtime via LoadLibrary* and dlopen.
I.e. if I am not mistaken test can be compiled even if those files don;'t exist. And only in runtime we need .so and .dll.
| @@ -47,6 +47,7 @@ class E2EExpr(BooleanExpression): | |||
| "pdtracker", | |||
| "ze_debug", | |||
| "device-config-file", | |||
| "sycl-jit", | |||
There was a problem hiding this comment.
If I am not mistaken we don't need this requirement at build-time, i.e. this is "run-mode" only feature and needs to be removed from this list. Please see my second comment.
The project may be built with --disable-jit.
Updating the tests that fail without this feature.