Skip to content

[SYCL][E2E] Remove preview/CXX11_ABI RUN lines from AbiNeutral/* #19743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][E2E] Remove preview/CXX11_ABI RUN lines from AbiNeutral/* #19743

wants to merge 1 commit into from

Conversation

aelovikov-intel
Copy link
Contributor

We test that combination in Nightly unconditionally on SPR/PVC

llvm/.github/workflows/sycl-nightly.yml

Lines 120 to 132 in efe036e

- name: Preview mode on SPR/PVC
runner: '["Linux", "pvc"]'
target_devices: level_zero:gpu
extra_lit_opts: --param test-preview-mode=True
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix.runner }}
image_options: ${{ matrix.image_options || '-u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN' }}
target_devices: ${{ matrix.target_devices }}
tests_selector: e2e
extra_lit_opts: "--param 'cxx_flags=-D_GLIBCXX_USE_CXX11_ABI=0' ${{ matrix.extra_lit_opts }}"
and that functionality isn't device/backend-dependent, so no need for extra RUN lines.

@aelovikov-intel
[SYCL][E2E] Remove preview/CXX11_ABI RUN lines from AbiNeutral/*
022bca5 
We test that combination in Nightly unconditionally on SPR/PVC
https://github.com/intel/llvm/blob/efe036e5b5f0229824f874d3fc489377877a0115/.github/workflows/sycl-nightly.yml#L120-L132
and that functionality isn't device/backend-dependent, so no need for
extra RUN lines.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner August 7, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @sergey-semenov