Skip to content

Conversation

@lkleinax
Copy link

@lkleinax lkleinax commented Oct 21, 2025

This pull request makes a targeted improvement to the regular expression used for parsing virtual function (VF) details in the Linux virtualization network interface code. The update ensures the code can handle both "link/ether" and "MAC" as possible labels for MAC addresses in the output of the ip link show command.

Parsing robustness:

  • Updated the regular expression in _get_vfs_details within linux.py to accept both link/ether and MAC as valid MAC address labels, improving compatibility with different output formats from ip link show.

Copilot AI review requested due to automatic review settings October 21, 2025 11:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regex pattern used to parse VF (Virtual Function) details from network interface information. The fix addresses issue #29 by making the pattern more flexible to handle different output formats from the ip link show command.

Key Change:

  • Modified the regex pattern to accept both "link/ether" and "MAC" as valid prefixes before the MAC address field in VF details parsing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lkleinax lkleinax force-pushed the fix__fix_regex_to_get_vfs_details_properly branch from 65450bf to 42a910e Compare October 29, 2025 10:39
mchromin
mchromin previously approved these changes Oct 29, 2025
@lkleinax lkleinax force-pushed the fix__fix_regex_to_get_vfs_details_properly branch from 42a910e to 95028ce Compare October 29, 2025 10:49
@lkleinax lkleinax force-pushed the fix__fix_regex_to_get_vfs_details_properly branch from 95028ce to d8fcaeb Compare October 29, 2025 11:38
@lkleinax lkleinax force-pushed the fix__fix_regex_to_get_vfs_details_properly branch from d8fcaeb to edb2855 Compare October 29, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants