Skip to content

Conversation

@sartil
Copy link
Contributor

@sartil sartil commented Apr 14, 2025

Summary

Passing signedness when creating unsigned integer for the storageType in type parser, to create an actual unsigned integer.

JIRA ticket

Related PR in NPU Compiler and/or OpenVINO repository with sub-module update

Other related tickets

List tickets for additional work, eg, something was found during review but you agreed to address it in another Jira

  • E-xxxxx

@sartil sartil requested a review from a team as a code owner April 14, 2025 16:17
@sartil sartil changed the title [EISW-164790] Minor fix to quant dialect TypeParser [EISW-164790] Minor fix to quant dialect's TypeParser Apr 14, 2025
@sartil
Copy link
Contributor Author

sartil commented Apr 14, 2025

check-mlir runs successfully:

image

@nikita-kud
Copy link
Contributor

check-mlir runs successfully:

image

fyi, there is a precommit job: pr_checks/pr_check_llvm_test — Tests Passed

Copy link
Contributor

@andrey-golubev andrey-golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test here? Also, would it be possible to submit this patch directly to upstream MLIR (and then cherry-pick to us)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants