Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Data management update to support SUA ifaces for Homogen OneDAL tables #2045

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

ENH: Data management update to support SUA ifaces for Homogen OneDAL tables #2045

wants to merge 22 commits into from

Conversation

samir-nasibli
Copy link
Contributor

@samir-nasibli samir-nasibli commented Sep 11, 2024 •
edited
Loading

Description

Data management update to support SUA ifaces.

  • implemented without dpctl as a build dependency.
  • DPC backend homogen tables enhanced to support __sycl_usm_array_interface__ protocol.
  • Common primitives to extend it for CSR tables support.
  • Covered by test.

Test statistics

  • TBD

TODO:

  • csr tables support
  • refactoring
  • addressing test fails/adopting tests
  • description
  • more test coverage

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

@samir-nasibli samir-nasibli added the enhancement New feature or request label Sep 12, 2024
samir-nasibli
samir-nasibli commented Sep 25, 2024
View reviewed changes
onedal/datatypes/_data_conversion.py Outdated
@@ -39,13 +39,32 @@ def _apply_and_pass(func, *args):


def from_table(*args):
return _apply_and_pass(_backend.from_table, *args)
return _apply_and_pass(convert_one_from_table, *args)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires enhancement for the each dataframe format type supported

samir-nasibli
samir-nasibli commented Sep 28, 2024
View reviewed changes
onedal/datatypes/_data_conversion.py Outdated
return func(args[0])
return tuple(map(func, args))
return func(args[0], **kwargs)
return tuple(map(func, args, kwargs))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic is broken. Should be fixed

@samir-nasibli
Copy link
Contributor Author

/intelci: run

@samir-nasibli
Copy link
Contributor Author

/intelci: run

@samir-nasibli samir-nasibli changed the title ENH: Data management update to support SUA ifaces ENH: Data management update to support SUA ifaces for Homogen OneDAL tables Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss will be requested when the pull request is marked ready for review Alexsandruss is a code owner

@icfaust icfaust Awaiting requested review from icfaust icfaust will be requested when the pull request is marked ready for review icfaust is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samir-nasibli