Changes for new cute apis prefetch transpose vnni #583
Conversation
rishi-yadav
added
the
Tests
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for new CuTe APIs for Intel XE architecture, specifically for 2D block operations including prefetch, transpose, and VNNI (Vector Neural Network Instructions) transforms. These tests validate the declaration and basic functionality of specialized 2D memory operations that require IGC version 2.18 or higher.
Key changes:
- Added four new test files for XE 2D copy operations, prefetch, VNNI, and transpose APIs
- Updated version check logic in existing MMA tests to use consistent condition format
- Integrated new test files into the CMake build configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/cute/intel_xe/xe_vnni_2d.cpp | Tests XE_LOAD_2D_VNNI API declarations and static members for 8-bit and 16-bit VNNI operations |
| test/unit/cute/intel_xe/xe_transpose_2d.cpp | Tests XE_LOAD_2D_TRANSPOSE API with constraint validation for 32-bit and 64-bit transpose operations |
| test/unit/cute/intel_xe/xe_copy_prefetch_2d.cpp | Tests XE_PREFETCH_2D operations with device kernel execution for various element types |
| test/unit/cute/intel_xe/xe_copy_2d_test.cpp | Comprehensive tests for XE_LOAD_2D/XE_STORE_2D with multiple data types and dimensions |
| test/unit/cute/intel_xe/mma.cpp | Updated IGC version check condition and added fallback test for unsupported versions |
| test/unit/cute/intel_xe/CMakeLists.txt | Added new test source files to build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
Missing article 'THE' before 'POSSIBILITY'. Should be 'EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE'.
| * OF THIS SOFTWARE, EVEN IF ADVISED OF POSSIBILITY OF SUCH DAMAGE. | |
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
1 participant
Created unit tests for Intel XE GPU 2D block operations
Files Added
xe_copy_prefetch_2d.cpp - XE_PREFETCH_2D operations
xe_vnni_2d.cpp - XE_LOAD_2D_VNNI API validation
xe_transpose_2d.cpp - XE_LOAD_2D_TRANSPOSE API validation
Test Results
6/6 tests passing (0ms execution time each)
3 prefetch tests (uint8, int16, float)
1 VNNI API test
2 transpose tests (API + constraints)