Fix for void ElementC in epilogue. #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitchawla1
force-pushed
the
dev/achawla/fix_void_c_in_epilogue
branch
from
3d09e67 to
21d2651
Compare
rolandschulz
approved these changes
Oct 30, 2025
taozha2
reviewed
Oct 31, 2025
tdeng5
approved these changes
Oct 31, 2025
amitchawla1
force-pushed
the
dev/achawla/fix_void_c_in_epilogue
branch
from
064b63e to
703e23b
Compare
Todo: Handle void ElementD Check if we need to handle assumption that accumulator is same as compute. Signed-off-by: Chawla, Amit K <[email protected]>
1. ElementC is 'void', ElementCompute and ElementOutput different in LinearCombination 2. ElementAccumulator and ElementC have different types D=Ax B + C; => BF16=BF16xBF16+BF16 <=>BF16=FP32+BF16
Signed-off-by: Chawla, Amit K <[email protected]>
amitchawla1
force-pushed
the
dev/achawla/fix_void_c_in_epilogue
branch
2 times, most recently
from
4363474 to
4d9276d
Compare
Signed-off-by: Chawla, Amit K <[email protected]>
amitchawla1
force-pushed
the
dev/achawla/fix_void_c_in_epilogue
branch
from
4d9276d to
db56f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: Handle void ElementD
Check if we need to handle assumption that accumulator is same as compute.
Test: Compiles for all generated kernels with void as Element type