[Reland] Install xpu codegen header to torch/include #1743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the header installation for the torch-xpu-ops codegen by updating include paths for XPU op headers and adjusting CMake scripts.
- Updated include directives in multiple XPU source files to reference the proper directory (ATen/ops).
- Modified CMakeLists.txt and Codegen.cmake to copy generated XPU op headers into stock PyTorch’s include directory.
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/*.cpp | Updated include paths from "xpu/ATen/ops" to "ATen/ops". |
| src/ATen/CMakeLists.txt | Added installation of generated XPU header files into ATen/ops. |
| cmake/Codegen.cmake | Introduced variable BUILD_TORCH_ATEN_GENERATED and header install commands to support header installation. |
guangyey
changed the title
guangyey
changed the title
guangyey
force-pushed
the
guangyey/codegen
branch
6 times, most recently
from
655b4fa to
b04c7b7
Compare
guangyey
changed the title
guangyey
added
windows_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses a code generation issue related to XPU. Currently, there are two separate codegen paths for XPU:
The corresponding build directories are:
build/aten/src/ATen(for stock PyTorch)build/xpu/ATen(for torch-xpu-ops)However, in the torch-xpu-ops codegen, we mistakenly omitted installing XPU op headers from
build/xpu/ATen/opstobuild/aten/src/ATen/ops. This PR fixes the issue and also removes some unnecessary code for better maintainability.Solution
We copy the codegen from torch-xpu-ops to stock PyTorch
Additional Context
The original PR is #1405
Fix pytorch/pytorch#145902