-
Notifications
You must be signed in to change notification settings - Fork 42
Add print message when UT is failed with segmentation fault #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Cheng, Penghui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds print messages to indicate which unit tests failed with segmentation faults. The key changes include tracking failing tests in a list and printing a failure message:
- Updates in several test runner files to capture and report failures
- Changing accumulation of test results to reassign the failure status in one instance
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
test/xpu/run_test_with_skip_mtl.py | Added failure list tracking and print failure message |
test/xpu/run_test_with_skip_lnl.py | Added failure list tracking and print failure message |
test/xpu/run_test_with_skip_bmg.py | Added failure list tracking and print failure message |
test/xpu/run_test_with_skip_arc.py | Added failure list tracking and print failure message |
test/xpu/run_test_with_only.py | Changed result accumulation and added print message |
test/xpu/extended/run_test_with_skip_mtl.py | Added print message in extended unit tests |
test/xpu/extended/run_test_with_skip_lnl.py | Added print message in extended unit tests |
test/xpu/extended/run_test_with_skip_bmg.py | Added print message in extended unit tests |
test/xpu/extended/run_test_with_skip_arc.py | Added print message in extended unit tests |
test/xpu/extended/run_test_with_skip.py | Added print message in extended unit tests |
Comments suppressed due to low confidence (4)
test/xpu/run_test_with_skip_mtl.py:25
- [nitpick] Consider rephrasing the failure message for grammatical accuracy, e.g. using 'has failures' when there is a single test failure or dynamically adjusting for plurality.
print(",".join(fail_test) + " have failures")
test/xpu/run_test_with_skip_lnl.py:25
- [nitpick] Consider rephrasing the failure message for grammatical accuracy, ensuring it reads clearly whether one or multiple tests fail.
print(",".join(fail_test) + " have failures")
test/xpu/run_test_with_skip_bmg.py:25
- [nitpick] Consider revising the failure message wording for clarity and grammatical correctness, e.g. handling singular/plural cases appropriately.
print(",".join(fail_test) + " have failures")
test/xpu/run_test_with_skip_arc.py:28
- [nitpick] Consider revising the failure message to improve grammatical accuracy, such as by using a conditional message for singular or plural failures.
print(",".join(fail_test) + " have failures")
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Add print message when UT is failed with segmentation fault.