Fix sycl event sync for ONEMKL #1757
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes error handling for SYCL ONEMKL routines by adding an explicit wait on the returned event before checking for asynchronous queue errors.
- Added
e.wait_and_throw()to force synchronous exception delivery from the SYCL event. - Retained
q.throw_asynchronous()to catch any queued errors after event completion.
Comments suppressed due to low confidence (1)
src/ATen/native/xpu/mkl/BatchLinearAlgebra.cpp:24
- [nitpick] It would be helpful to add a comment explaining why both
wait_and_throw()andthrow_asynchronous()are used here to clarify the error-handling strategy for future maintainers.
e.wait_and_throw(); \
| @@ -21,6 +21,7 @@ namespace at::native::xpu { | |||
| #define SYCL_ONEMKL_SUBMIT(q, routine, ...) \ | |||
| { \ | |||
| auto e = (routine(__VA_ARGS__)); \ | |||
| e.wait_and_throw(); \ | |||
There was a problem hiding this comment.
Adding a synchronous wait on the SYCL event will block the host thread for each submission, which may degrade throughput. Consider whether per-event blocking is necessary or if errors can be batched or handled asynchronously.
Suggested change
| e.wait_and_throw(); \ | |
| e.wait(); \ |
Copilot uses AI. Check for mistakes.
CuiYifeng
changed the title
CuiYifeng
force-pushed
the
yifeng/fix_sync
branch
from
bae7108 to
0091588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.