Add Float8_e8m0fnu support for copy #2258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Float8_e8m0fnu support for copy operations on XPU backend to solve issue #2207. The changes enable Float8_e8m0fnu dtype for various tensor operations including copy, flip, and indexing operations.
- Added Float8_e8m0fnu support to copy kernel with proper casting functions
- Updated dispatch macros to include all Float8 types using AT_FLOAT8_TYPES
- Enabled Float8_e8m0fnu in test coverage by removing skip list entries
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/xpu/skip_list_common.py | Removed Float8 skip for indexing tests |
| test/regressions/test_index_and_index_put.py | Added Float8 flip test including Float8_e8m0fnu |
| test/regressions/test_copy.py | Added Float8_e8m0fnu test coverage for copy operations |
| src/ATen/native/xpu/sycl/TensorTransformationsKernels.cpp | Updated flip kernel to support Float8 types |
| src/ATen/native/xpu/sycl/Indexing.cpp | Updated indexing kernels to support Float8 types |
| src/ATen/native/xpu/sycl/CopyKernel.cpp | Added Float8_e8m0fnu copy kernel implementation |
| src/ATen/native/xpu/XPUScalar.cpp | Added Float8 types to scalar conversion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Depends on #2190. |
19 tasks
CuiYifeng
force-pushed
the
yifeng/fp8_e8m0_copy
branch
from
c525192 to
aeeb7f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #2207
This PR is to support Float8_e8m0fnu copy on XPU backend.