Enable Float4_e2m1fn_x2 to Float4_e2m1fn_x2 copy #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables copying tensors with the Float4_e2m1fn_x2 data type on XPU devices by adding kernel support and extending test coverage. This addresses issue #2305 by implementing the missing copy operation for this float4 type.
Key changes:
- Added
float4_copy_kernel_xpufunction to handle Float4_e2m1fn_x2 copy operations - Extended test coverage to include Float4_e2m1fn_x2 dtype in copy/clone tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/CopyKernel.cpp | Implements float4 copy kernel and integrates it into the main copy_kernel dispatch logic |
| test/regressions/test_copy.py | Adds Float4_e2m1fn_x2 to the test dtypes for copy and clone operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
CuiYifeng
force-pushed
the
yifeng/fp4_copy
branch
from
24cd909 to
48cd4bb
Compare
liangan1
approved these changes
Nov 12, 2025
Stonepia
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #2305.
This PR adds support for copying tensors with the
Float4_e2m1fn_x2data type on XPU devices.