Fix UT for FP8 concat #2348
Open
Fix UT for FP8 concat #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FP8 concatenation unit test to use PyTorch's standard test infrastructure instead of manual dtype iteration. The main changes improve test maintainability and consistency with PyTorch testing conventions.
Key Changes:
- Replaced manual float8 dtype iteration with the
@dtypesdecorator - Integrated with PyTorch's device type testing framework for XPU devices
- Added proper test instantiation and runner boilerplate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dtypes, | ||
| instantiate_device_type_tests, | ||
| ) | ||
| from torch.testing._internal.common_dtype import float8_types_and |
There was a problem hiding this comment.
The import name 'float8_types_and' appears to be incomplete. It should likely be 'float8_types' or similar. Please verify the correct function name from torch.testing._internal.common_dtype.
CuiYifeng
force-pushed
the
yifeng/fix_fp8_cat_ut
branch
from
585ed3a to
69230c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.