This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
IWD as P2P backend #196
Open
balrog-kun
wants to merge
8
commits into
intel:master
Choose a base branch
from
balrog-kun:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
IWD as P2P backend #196
Commits on May 24, 2020
-
Create a Client::Parameters struct to avoid passing IEs
IWD doesn't accept or export raw IEs on the DBus interface, instead it takes individual parameter values and only a subset of all the ones that the IEs contain. Make the connman-specific Client class build the IE locally from an abstract parameters struct. For now the struct contains the values that source-app.cpp and sink-app.cpp use, if they need to indicate support for any of the extended WFD capabilities or other parameters, this struct will have to be extended too. This might also be a step in supporting Miracast over Ethernet (MICE?) if ever needed -- I think this is the name used for the R2-specific connection method where parameters are exposed as mDNS records.
Configuration menu - View commit details
-
Copy full SHA for 9841d5d - Browse repository at this point
Copy the full SHA 9841d5dView commit details -
Add P2P::Client and Peer base clases
In order to support other clients than Connman, rename P2P::Client to P2P::ConnmanClient and P2P::Peer to P2P::ConnmanPeer while making them subclasses of new base clases P2P::Client and P2P::Peer. Those base classes are abstract and only have what is expected to be common between Connman and IWD.
Configuration menu - View commit details
-
Copy full SHA for ab83c8e - Browse repository at this point
Copy the full SHA ab83c8eView commit details
Commits on Jul 19, 2020
-
p2p: Move struct Parameters to peer.h and out of the Client class
Make the struct global within the P2P namespace so it can be used in the Peer class as a utility struct.
Configuration menu - View commit details
-
Copy full SHA for 7374b98 - Browse repository at this point
Copy the full SHA 7374b98View commit details -
Similar to the DBus-based Connman client add a DBus-based IWD client for managing peer discovery, connection/disconnection and P2P service registation using the IWD DBus-service.
Configuration menu - View commit details
-
Copy full SHA for e08e1a2 - Browse repository at this point
Copy the full SHA e08e1a2View commit details -
To avoid forcing the source/sink apps to select between one client or another, add the MultiClient class, implementing P2P::Client, so that it can be a drop-in replacement of ConnmanClient that does the right thing depending on which of the two services are available on DBus. Under the hood it hold objects of both ConnmandClient and IWDClient and whichever detects its corresponding daemon is available for use, forwards any callbacks through MultiClient up to the app.
Configuration menu - View commit details
-
Copy full SHA for 73d6b5a - Browse repository at this point
Copy the full SHA 73d6b5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd92ddc - Browse repository at this point
Copy the full SHA bd92ddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d8643e - Browse repository at this point
Copy the full SHA 9d8643eView commit details
Commits on Jul 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5f04bd9 - Browse repository at this point
Copy the full SHA 5f04bd9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.