Add detection of plugin child process log level #1736
Conversation
| func logCapturedLine(entry *log.Entry, text string) { | ||
| lc := strings.ToLower(text) | ||
| switch { | ||
| case strings.Contains(lc, "error"): |
There was a problem hiding this comment.
@cce I think it is not a good idea to detect log level in this way.
For example, the message 'warn: cannot collect metric /xx/xx/xx/error_rate from xxx platform' will be an error instead of warning in your case.
There was a problem hiding this comment.
You're right that your example line would be considered an error — I was looking for a quick solution to ensure that a plugin's error logs are not logged at "DEBUG" level. What do you think is the best approach? Could we assume logrus format and look for level=error?
There was a problem hiding this comment.
@cce I think parsing "level=error" like strings approach is acceptable. Though it will not be perfect (may be confused if this phrase occurred in log message), but the probability is rather low and the cost is not too high.
This attempts to guess if a plugin is reporting an Error, Warning, or Info log message so that when snapteld reads the captured output, it can log the message at the same level.
@intelsdi-x/snap-maintainers