Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major Linting and security fixes #299

Merged
merged 29 commits into from
Oct 10, 2024
Merged

Major Linting and security fixes #299

merged 29 commits into from
Oct 10, 2024

Conversation

dciangot
Copy link
Collaborator

@dciangot dciangot commented Oct 4, 2024 •
edited
Loading

Summary

This is a first draft for fixing all the linting. A new start hopefully!

  • Removing code duplicates introducing dedicated functions
  • HTTP connections secure by default (disable through expliciit configuration allowed)
  • linting in github actions are now ALL green and so they should remain

Related issue :

@dciangot
go linting
5908fc9 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
go linting
4555735 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
go security linting
e57c899 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
go security linting ended
c8fde5a 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
go duplicates linting
c9c5b0b 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
go duplicates linting doc for insecure http
f90dbb8 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
copy clone lint and golint fixed in /pkg
6c9ff8d 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
copy clone lint and golint fixed in /cmd - one try
25e39e3 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
try fix gh action
e13ce1f 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
bump superlinter gh action
e122b4c 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
bump superlinter gh action
e146db2 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
exclude paths to jcspd
3214cf9 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
exclude paths to jcspd
2423f58 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
second round linting configuration for gh actions
0fe5197 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
second round linting configuration for gh actions
0504b9b 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
second round linting configuration for gh actions
c0eca98 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
second round linting configuration for gh actions
0cc7638 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
second round linting configuration for gh actions
66be9a8 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
no lint python in example
2042761 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
no lint python in example
6e60e98 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
no lint python in example
5adc5ca 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
no lint python in example
7ebb8c2 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
golangcilint only
1974088 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
golangcilint only
6c908b8 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
golangcilint only
0478320 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
fix integration test now
e0960ed 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
fix integration test now
975371b 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot dciangot requested a review from Bianco95 October 5, 2024 15:42
Bianco95
Bianco95 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@Bianco95 Bianco95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dciangot
lint in dagger ci tests
c79e733 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot
update doc for 0.3.1
8929891 
Signed-off-by: Diego Ciangottini <[email protected]>
@dciangot dciangot merged commit d19004b into interTwin-eu:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bianco95 Bianco95 Bianco95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dciangot @Bianco95