Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename init function of distributed strategies #247

Closed
annaelisalappe opened this issue Nov 14, 2024 · 1 comment
Closed

Rename init function of distributed strategies #247

annaelisalappe opened this issue Nov 14, 2024 · 1 comment

Comments

@annaelisalappe
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
It's not really a problem, but the name of the init function imo is not clearly enough distinguished from the init function of the same class (and every class, really).

Describe the solution you'd like
Renaming it something like initialize_distributed_strategy(..) would make it clearer that is corresponds to the initialisation of the distributed backend, not the class itself.

Yuvrajsinghspd09 added a commit to Yuvrajsinghspd09/itwinai that referenced this issue Jan 13, 2025
- Updated init to initialize_distributed_strategy in:n
  - TorchDDPStrategy

  - DeepSpeedStrategy

- Ensured method names clearly reflect their purpose.
@annaelisalappe
Copy link
Collaborator Author

After discussions with the team, this is a non-issue - since other comparative frameworks use the same naming conventions, renaming it would actually likely not add any more clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant