#247 - Rename init to initialize_distributed_strategy #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated init to initialize_distributed_strategy in:n - TorchDDPStrategy - DeepSpeedStrategy - Ensured method names clearly reflect their purpose.
|
Actually, we have closed the issue as after discussions with the team, we decided the current naming conventions are fine. Thank you for your effort, we will do our best to keep issues up-to-date in the future! |
Oh okay! . Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #247 by renaming the
initmethod toinitialize_distributed_strategyfor distributed strategies.Changes made :
TorchDDPStrategyandDeepSpeedStrategyto useinitialize_distributed_strategy.@annaelisalappe Could you please review this pull request? Let me know if any further changes are needed.
Summary
Related issue :