Merge pull request #222 from intercom/conor/deps-fix

Only check the `compile` configuration for dependencies
intercom · Nov 16, 2017 · 00ebf72 · 00ebf72
2 parents d7fa9fd + bd19d82
commit 00ebf72
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/intercom-plugin/src/android/build-extras-intercom.gradle b/intercom-plugin/src/android/build-extras-intercom.gradle
@@ -36,7 +36,7 @@ afterEvaluate {
     logIfIncorrectCompileSdkVersion()
     logIfIncorrectBuildToolsVersion()
     configurations
-            .findAll { isCompileConfig(it) }
+            .findAll { it.name == "compile" }
             .each { logIncompatibleDependencies(it) }
 }
 
@@ -67,13 +67,6 @@ private void logIfIncorrectBuildToolsVersion() {
     }
 }
 
-private static boolean isCompileConfig(config) {
-    // these can be `compile` or `{variant}Compile`
-    config.name =~ /^[a-z][a-zA-Z]*ompile/ \
-        && !(config.name =~ /^test.*Compile/) \
-        && !(config.name =~ /^androidTest.*Compile/)
-}
-
 private void logIncompatibleDependencies(config) {
     config.resolvedConfiguration.resolvedArtifacts.each {
         def artifact = it.moduleVersion.id